Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

58 bug batch 2 backend #61

Merged
merged 4 commits into from
Mar 21, 2024
Merged

58 bug batch 2 backend #61

merged 4 commits into from
Mar 21, 2024

Conversation

h0ethan04
Copy link
Contributor

Bugfixes:

  • Updated catalog and PS schemas, enforced unique date in day table.
  • Get requests for catalog now only return events that are not hidden
  • Post request for catalog sets default value of hidden to false
  • Deleting catalog item deletes from catalog table if it the id is not used in PS table, else sets hidden to true
  • Fixed query for PS put request

Closes #58

@h0ethan04 h0ethan04 self-assigned this Mar 13, 2024
michellelin1
michellelin1 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@michellelin1 michellelin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks for also fixing other things! :)

@michellelin1 michellelin1 merged commit b5327bf into dev Mar 21, 2024
3 checks passed
@michellelin1 michellelin1 deleted the 58-bug-batch-2-backend branch March 21, 2024 22:31
@ThatMegamind ThatMegamind linked an issue Mar 21, 2024 that may be closed by this pull request
Bug Batch 2 (Backend) #58
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellelin1 michellelin1 michellelin1 approved these changes

@ThatMegamind ThatMegamind Awaiting requested review from ThatMegamind

Assignees

@h0ethan04 h0ethan04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Batch 2 (Backend)
2 participants
@h0ethan04 @michellelin1